[ros-dev] [ros-diffs] [hbelusca] 63599: [TASKMGR]: Use the EndTask API to kill tasks.

Mon Jun 16 11:11:49 UTC 2014

+1 @ Ged, yes I prefer having a 1 or 0 instead of something else (in case somebody after makes a “ForceEndTask == TRUE” comparison instead of just checking for non-zero value of ForceEndTask).

H.

De : Ros-dev [mailto:ros-dev-bounces at reactos.org] De la part de Ged Murphy
Envoyé : lundi 16 juin 2014 12:48
À : 'ReactOS Development List'
Objet : Re: [ros-dev] [ros-diffs] [hbelusca] 63599: [TASKMGR]: Use the EndTask API to kill tasks.

They produce the same asm.

From: Ros-dev [mailto:ros-dev-bounces at reactos.org] On Behalf Of David Quintana (gigaherz)
Sent: 16 June 2014 11:10
To: ReactOS Development List
Subject: Re: [ros-dev] [ros-diffs] [hbelusca] 63599: [TASKMGR]: Use the EndTask API to kill tasks.

It's equivalent to writing "<something> != 0", although less readable. I have no idea if compilers actually generate better code for it, or people just do it because it's shorter to type.

On 16 June 2014 11:09, Ged Murphy <gedmurphy.maillists at gmail.com> wrote:

Yes, the double negate is a little trick to give you either a 1 or a 0 instead of the value of the operation.

-----Original Message-----
From: Ros-dev [mailto:ros-dev-bounces at reactos.org] On Behalf Of Pierre Schweitzer
Sent: 16 June 2014 07:31
To: ros-dev at reactos.org
Subject: Re: [ros-dev] [ros-diffs] [hbelusca] 63599: [TASKMGR]: Use the EndTask API to kill tasks.

On 15/06/2014 19:47, hbelusca at svn.reactos.org wrote:
> +    /* Trick: on Windows, pressing the CTRL key forces the task to be ended */
> +    BOOL ForceEndTask = !!(GetKeyState(VK_CONTROL) & 0x8000);
> +

Was it really meant to be '!!'?

--
Pierre Schweitzer<pierre at reactos.org> System Administrator ReactOS Foundation

_______________________________________________
Ros-dev mailing list
Ros-dev at reactos.org
http://www.reactos.org/mailman/listinfo/ros-dev

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.reactos.org/pipermail/ros-dev/attachments/20140616/d9c47ea7/attachment-0001.html>