[ros-dev] [ros-diffs] [tfaber] 63030: [FIND] - Avoid printf on a non-format string. Spotted by Víctor - Remove broken pseudo-TCHAR usage CORE-8112 #resolve

Timo Kreuzer timo.kreuzer at web.de
Tue Apr 29 06:13:07 UTC 2014


Am 28.04.2014 10:06, schrieb tfaber at svn.reactos.org:
> @@ -235,9 +235,9 @@
>  	        }
>   	      else
>  	        {
> -	          LoadString(GetModuleHandle(NULL), IDS_CANNOT_OPEN, (LPTSTR)lpMessage, 4096);
> -	          CharToOem(lpMessage, lpMessage);
> -	          fprintf (stderr, lpMessage,
> +	          LoadString (GetModuleHandle (NULL), IDS_CANNOT_OPEN, szMessage, sizeof(szMessage) / sizeof(szMessage[0]));
> +	          CharToOemA (szMessage, szMessage);
> +	          fprintf (stderr, szMessage,
>  		           finddata.name);
>                  }

LoadString -> LoadStringA?
Also, shouldn't we go unicode?




More information about the Ros-dev mailing list