[ros-dev] [ros-diffs] [pschweitzer] 62779: [CDFS] Convert FCB pathname from simple buffer to unicode string. Please carefully review if I missed something

Sat Apr 19 15:23:57 UTC 2014

Fix committed in revision 62807, cheers.

Hermès.

-----Message d'origine-----
De : Ros-dev [mailto:ros-dev-bounces at reactos.org] De la part de Pierre Schweitzer
Envoyé : samedi 19 avril 2014 15:58
À : ReactOS Development List
Objet : Re: [ros-dev] [ros-diffs] [pschweitzer] 62779: [CDFS] Convert FCB pathname from simple buffer to unicode string. Please carefully review if I missed something

Hey!
That's indeed a typo!
Can someone commit a fix? I can't before Monday evening.
Thanks!

Pierre

-------- Message original --------
Objet : Re: [ros-dev] [ros-diffs] [pschweitzer] 62779: [CDFS] Convert FCB pathname from simple buffer to unicode string. Please carefully review if I missed something De : Alexander Andrejevic <theflash at sdf.lonestar.org> À : ReactOS Development List <ros-dev at reactos.org> Cc : 

Hi,

Correct me if I'm wrong, but the original version didn't modify the string length.
Are you sure that should be "=" and not "=="?

Regards,
Alex

On Sat, Apr 19, 2014 at 09:31:44AM +0200, Thomas Faber wrote:
> On 2014-04-18 23:40, pschweitzer at svn.reactos.org wrote:
> > --- trunk/reactos/drivers/filesystems/cdfs/fcb.c	[iso-8859-1] (original)
> > +++ trunk/reactos/drivers/filesystems/cdfs/fcb.c	[iso-8859-1] Fri Apr 18 21:40:02 2014
> > @@ -129,7 +131,7 @@
> >  BOOLEAN
> >  CdfsFCBIsRoot(PFCB Fcb)
> >  {
> > -    return(wcscmp(Fcb->PathName, L"\\") == 0);
> > +    return (Fcb->PathName.Length = sizeof(WCHAR) && 
> > + Fcb->PathName.Buffer[0] == L'\\');
> >  }
> 
> ==
> 
> 
> 
> Generally I'm seeing a lot of manual work where 
> RtlInitEmptyUnicodeString and RtlCopyUnicodeString could be used.
> 
> _______________________________________________
> Ros-dev mailing list
> Ros-dev at reactos.org
> http://www.reactos.org/mailman/listinfo/ros-dev

--
Alexander Andrejevic <theflash at sdf.lonestar.org> SDF Public Access UNIX System - http://sdf.lonestar.org

_______________________________________________
Ros-dev mailing list
Ros-dev at reactos.org
http://www.reactos.org/mailman/listinfo/ros-dev
_______________________________________________
Ros-dev mailing list
Ros-dev at reactos.org
http://www.reactos.org/mailman/listinfo/ros-dev