[ros-dev] [ros-diffs] [hbelusca] 62662: [NTDLL_APITEST]: Add braces and remove an unneeded trace.
Thomas Faber
thomas.faber at reactos.org
Sun Apr 6 18:00:51 UTC 2014
Yes, it's a common pattern. The nice way is just to have all ok() prints
in the loop include the index. I'm sometimes too lazy for that though
so I add traces like this one.
On 2014-04-06 20:02, Hermès BÉLUSCA - MAÏTO wrote:
> Ok so in fact, this think must be generalized to each time we have tests in
> form of a loop :)
>
> -----Message d'origine-----
> De : Ros-dev [mailto:ros-dev-bounces at reactos.org] De la part de Thomas Faber
> Envoyé : dimanche 6 avril 2014 18:10
> À : ros-dev at reactos.org
> Objet : Re: [ros-dev] [ros-diffs] [hbelusca] 62662: [NTDLL_APITEST]: Add
> braces and remove an unneeded trace.
>
> This will make any failure messages in the loop useless, since you won't
> know which test they're about.
> Just because the tests are succeeding now doesn't mean they always will.
>
> On 2014-04-06 17:51, hbelusca at svn.reactos.org wrote:
>> @@ -188,7 +190,6 @@
>>
>> for (i = 0; i < TestCount; i++)
>> {
>> - trace("i = %d\n", i);
>> switch (TestCases[i].PrefixType)
>> {
>> case PrefixNone:
>>
>>
More information about the Ros-dev
mailing list