[ros-dev] [ros-diffs] [jimtabor] 60682: [Win32ss] - Prevent a potential kernel exception.

Thomas Faber thomas.faber at reactos.org
Tue Oct 15 22:24:11 UTC 2013


On 2013-10-16 00:14, jimtabor at svn.reactos.org wrote:
> URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/user/user32/windows/prop.c?rev=60682&r1=60681&r2=60682&view=diff
> ==============================================================================
> --- trunk/reactos/win32ss/user/user32/windows/prop.c	[iso-8859-1] (original)
> +++ trunk/reactos/win32ss/user/user32/windows/prop.c	[iso-8859-1] Tue Oct 15 22:14:48 2013
> @@ -53,6 +53,7 @@
>    for (i = 0; i < pWnd->PropListItems; i++ )
>    {
>        Property = CONTAINING_RECORD(ListEntry, PROPERTY, PropListEntry);
> +      if (!Property) break;
>        if (Property->Atom == Atom)
>        {
>           return(Property);
> 
> 

That can't happen unless the list is corrupt.
And even if the list contains a null pointer (which it's not supposed
to), ListEntry would be NULL, not Property.



More information about the Ros-dev mailing list