[ros-dev] [ros-diffs] [ekohl] 59013: [LSASRV] - LsapCheckLogonProcess: Open client process using the PROCESS_DUP_HANDLE access right because we need to duplicate the logon token back into the clients handle table.

Thomas Faber thfabba at gmx.de
Tue May 14 09:10:11 UTC 2013


On 2013-05-13 15:05, ekohl at svn.reactos.org wrote:
>          Status = NtReplyWaitReceivePort(AuthPortHandle,
>                                          (PVOID*)&LogonContext,
> -                                        &ReplyMsg->h,
> -                                        &RequestMsg.h);
> +                                        (PPORT_MESSAGE)ReplyMsg,
> +                                        (PPORT_MESSAGE)&RequestMsg);

As the Guy Who Officially Hates Casts™, I have to ask: wasn't the
previous version better for type safety? With the cast, an additional
[or missing] & can slip in and the code will compile without complaint.

Best,
Thomas



More information about the Ros-dev mailing list