[ros-dev] [ros-diffs] [akhaldi] 59598: [CMAKE/GCC] * Compile debug builds using -O1 instead of -Os. This results in faster compilation time with no measurable difference in runtime performance according to tests. CORE-7...

[Timo Kreuzer]

It used to be Os (optimize for size). not O2.
We could use O2 for the release builds IMO.

Timo

Am 31.07.2013 16:39, schrieb Alex Ionescu:
> I don't really like this. Maybe only do this on the build server, or
> at least don't do it to kernel code. "Measurable" difference in
> performance doesn't really mean much on an OS that does not have any
> performance infrastructure, but trust me, there's a difference between
> O1 and O2.
>
> Best regards,
> Alex Ionescu
>
>
> On Wed, Jul 31, 2013 at 6:04 AM, <akhaldi at svn.reactos.org
> <mailto:akhaldi at svn.reactos.org>> wrote:
>
>     Author: akhaldi
>     Date: Wed Jul 31 13:04:38 2013
>     New Revision: 59598
>
>     URL: http://svn.reactos.org/svn/reactos?rev=59598&view=rev
>     Log:
>     [CMAKE/GCC]
>     * Compile debug builds using -O1 instead of -Os. This results in
>     faster compilation time with no measurable difference in runtime
>     performance according to tests.
>     CORE-7374 #resolve #comment Committed in r59598.
>
>     Modified:
>         trunk/reactos/cmake/config.cmake
>
>     Modified: trunk/reactos/cmake/config.cmake
>     URL:
>     http://svn.reactos.org/svn/reactos/trunk/reactos/cmake/config.cmake?rev=59598&r1=59597&r2=59598&view=diff
>     ==============================================================================
>     --- trunk/reactos/cmake/config.cmake    [iso-8859-1] (original)
>     +++ trunk/reactos/cmake/config.cmake    [iso-8859-1] Wed Jul 31
>     13:04:38 2013
>     @@ -10,7 +10,7 @@
>      set(TUNE "i686" CACHE STRING
>      "Which CPU ReactOS should be optimized for.")
>
>     -set(OPTIMIZE "1" CACHE STRING
>     +set(OPTIMIZE "4" CACHE STRING
>      "What level of optimization to use.
>       0 = off
>       1 = Default option, optimize for size (-Os) with some additional
>     options
>
>
>
>
>
> _______________________________________________
> Ros-dev mailing list
> Ros-dev at reactos.org
> http://www.reactos.org/mailman/listinfo/ros-dev

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.reactos.org/pipermail/ros-dev/attachments/20130731/4e6f6a6e/attachment.html>