[ros-dev] [ros-diffs] [hbelusca] 58110: while (TRUE); (when something is unimplemented) ---> ASSERT(FALSE); // while (TRUE); (unless we deal with a 'noreturn' function), and in some cases, return an adequate value. Part...

[Hermès BÉLUSCA - MAÏTO]

Hi !

Today or tomorrow (i.e. this week-end), I will arrange that and put the
Assert(false); // while(true); into a better form (doing a real break) and
introduce, as Aleksey has suggested, a UNIMPLEMENTED_FATAL() macro which
does all that.
As some people "complained" on IRC yesterday about keeping the //
while(true); comment in the code, it makes easiest to find the portions of
the code where the while(true); where placed in order to "stop" the
execution of code because of unimplemented feature, rather than what I call
a "legitimate" while(true); coming from, e.g., code like: do { /* something
with break; */ } while(true); . In other words, doing a search in the code
for the string ' ASSERT(FALSE); // while (TRUE); ' gives you instantly the
places where the original while(true); for unimplemented features, were.

Hermès

-----Message d'origine-----
De : ros-dev-bounces at reactos.org [mailto:ros-dev-bounces at reactos.org] De la
part de Timo Kreuzer
Envoyé : vendredi 4 janvier 2013 22:50
À : ReactOS Development List
Objet : Re: [ros-dev] [ros-diffs] [hbelusca] 58110: while (TRUE); (when
something is unimplemented) ---> ASSERT(FALSE); // while (TRUE); (unless we
deal with a 'noreturn' function), and in some cases, return an adequate
value. Part...

Am 04.01.2013 22:39, schrieb Timo Kreuzer:
> Especially in usermode and at high irql
Sorry I meant at low irql!



_______________________________________________
Ros-dev mailing list
Ros-dev at reactos.org
http://www.reactos.org/mailman/listinfo/ros-dev