[ros-dev] [ros-diffs] [hbelusca] 57701: [CSRSRV] - Use a variable ServerDll instead of using each time CsrLoadedServerDll[i], as it is done in some other places. - Clean the code (remove extra-parentheses). - Zero-out t...

[Riccardo Bestetti]

Well, I was just giving you my opinion. Also, I often read ReactOS source code, I've learned a lot of things from it!

From: ionucu at videotron.ca
Date: Wed, 14 Nov 2012 12:46:28 -0800
To: ros-dev at reactos.org
Subject: Re: [ros-dev] [ros-diffs] [hbelusca] 57701: [CSRSRV] - Use a variable ServerDll instead of using each time CsrLoadedServerDll[i], as it is done in some other places. - Clean the code (remove extra-parentheses). - Zero-out t...

With all due respect Riccardo, this isn't an issue up for debate among users -- this is a developer-internal matter.
Hermes, there are good reasons why we pick double () around things, mainly around consistency. If you feel the need to start a discussion around coding style, please do so, on the proper channel and involve the devs, but don't start re-writing other people's code that was conformant to the design guidelines! This is what's worse about your change: it's not that you decide do ignore our style guidelines (which would already be bad), it's that you decided to rewrite someone else's code (that was respecting guidelines)!

Best regards,
Alex Ionescu



On Wed, Nov 14, 2012 at 12:08 PM, Riccardo Bestetti <riccardo.kyogre at live.it> wrote:






It makes it easier to read in my opinion! And the code looks more clean.
Regards,Riccardo Bestetti

From: hermes.belusca at sfr.fr


To: ros-dev at reactos.org
Date: Wed, 14 Nov 2012 20:15:36 +0100
Subject: Re: [ros-dev] [ros-diffs] [hbelusca] 57701: [CSRSRV] - Use a variable ServerDll instead of using each time CsrLoadedServerDll[i], as it is done in some other places. - Clean the code (remove extra-parentheses). - Zero-out t...



I did the change because I don’t see the point having extra-parentheses around a single term (ServerDll , or ServerDll->HardErrorCallback), it makes reading difficult (but I’m of course ok with such things : if ((var_1 >= a) && (var_1 <= b))     ), and furthermore this thing happens only in these instructions : if ((ServerDll) && (ServerDll->A_Callback)) or if ((CsrLoadedServerDll[i]) && (CsrLoadedServerDll[i]->SizeOfProcessData)) in the code…

 Regards,

Hermès BÉLUSCA - MAÏTO

 De : ros-dev-bounces at reactos.org [mailto:ros-dev-bounces at reactos.org] De la part de Alex Ionescu


Envoyé : mercredi 14 novembre 2012 05:34
À : ReactOS Development List
Objet : Re: [ros-dev] [ros-diffs] [hbelusca] 57701: [CSRSRV] - Use a variable ServerDll instead of using each time CsrLoadedServerDll[i], as it is done in some other places. - Clean the code (remove extra-parentheses). - Zero-out t...

 Would you mind not "cleaning up formatting" by going against our coding style and doing the very thing I even taught you not to do during your initial patches/code reviews? 

Thanks.Best regards,
Alex Ionescu

On Tue, Nov 13, 2012 at 1:08 PM, <hbelusca at svn.reactos.org> wrote:

-        if ((ServerDll) && (ServerDll->HardErrorCallback))
+        if (ServerDll && ServerDll->HardErrorCallback) 
_______________________________________________
Ros-dev mailing list
Ros-dev at reactos.org
http://www.reactos.org/mailman/listinfo/ros-dev 		 	   		  

_______________________________________________

Ros-dev mailing list

Ros-dev at reactos.org

http://www.reactos.org/mailman/listinfo/ros-dev





_______________________________________________
Ros-dev mailing list
Ros-dev at reactos.org
http://www.reactos.org/mailman/listinfo/ros-dev 		 	   		  
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.reactos.org/pipermail/ros-dev/attachments/20121115/24da7c9f/attachment.html>