[ros-dev] Re : [ros-diffs] [jgardou] 56082: [DAMN_IT] - addendum to r56081

Aleksey Bragin aleksey at reactos.org
Thu Mar 8 16:46:24 UTC 2012


On 08.03.2012 20:03, Kamil Hornicek wrote:
> I don't per se oppose the idea to have tests in corresponding folders, 
> provided they are maintained and updated (winetests). But I am 
> strongly against merging everything from rostests just for the sake of 
> merging (because "these things belong togehter").
I explained these concerns when the initial tree restructure discussion 
(flamewar) came up. Sometimes, in some cases, it's reasonable, sometimes 
it's not.

Modularity should be a big advantage, and what I see so far is that the 
only reason was that "these things belong together". (I won't comment on 
the "nowhere to commit" fun, but really if someone doesn't care to 
checkout rostests and commit there, then something is wrong with that 
particular developer, not the development methods).

Or ACKing a definitive statement, like "every module should have a 
./test folder containing all related tests.".
I reread the discussion, and so far the only technical reason was from 
Caemyr, which suggests that it makes the testing process(?) simpler.

What I highly dislike in any project is doing something just for the 
sake of doing something. Things should be done to actually improve the 
situation and solve specific problems. Otherwise we will waste years 
restructuring trees, changing version control system or whatever else. 
There is the kernel, there is the OS - fix it, make it usable, profit.

WBR,
Aleksey.




More information about the Ros-dev mailing list