[ros-dev] [project-tools] Revision 1363: [ROSBE-UNIX] Implement support for pre-build & post-build hook scripts in RosBE-Unix.

[Pierre Schweitzer]

Oops. I only replied to Colin.

So, here was my answer:

You misunderstood purpose of hook scripts. Well, the example was pretty
bad, I recognize.

The idea of hook scripts is to allow providing external programs that
can modulate what RosBE does WITHOUT re-releasing the whole thingy for a
small change. This makes it modular and is a step forward.
Those are not here for CMake or whatever. Those are here for what the
user wants.

Regarding the specific CMake change, this is temporary on Amine's
request till a proper solution is deployed. I thought it was just a nice
opportunity to have a (bad) example to show what hook scripts can do.

Le dimanche 29 janvier 2012 à 11:03 +0100, Jérôme Gardou a écrit :
> Le 28/01/2012 23:30, Colin Finck a écrit :
> > pschweitzer at svn.reactos.org wrote:
> > > touch boot/bootdata/packages/reactos.dff.in
> >
> > We can't put this one-liner into the CMakeLists.txt file?
> > execute_process should do the job if there is no "touch" command in 
> > CMake itself.
> >
> > Your change makes RosBE depend on a very specific file in a very 
> > specific path of the source tree (=> tree change only possible with an 
> > updated RosBE). In addition, these hooks separate the build logic 
> > between CMake and RosBE and pave the way for even more source tree 
> > dependent changes in RosBE. I like to avoid this.
> >
> >
> > - Colin
> >
> > _______________________________________________
> > Ros-dev mailing list
> > Ros-dev at reactos.org
> > http://www.reactos.org/mailman/listinfo/ros-dev
> I don't know why this is needed at all, but in cmake files you can use 
> "cmake -E touch" for portability (windows have no default touch afaik)
> 
> _______________________________________________
> Ros-dev mailing list
> Ros-dev at reactos.org
> http://www.reactos.org/mailman/listinfo/ros-dev

-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 4016 bytes
Desc: not available
URL: <http://www.reactos.org/pipermail/ros-dev/attachments/20120129/630df7cf/attachment.bin>