[ros-dev] [ros-diffs] [fireball] 53635: - Downgrade someDPRINT1s to DPRINTs.

[Aleksey Bragin]

Very easy, I explained you in the previous email. If the reminder has no sense, for example as it was with NTDLL LDR debug prints – they warned about a not implemented app compat hacks querying, which was never implemented before, then there is no reason to remind about it at the load of every executable image in ReactOS.
Same applies to other stuff.

However, if the certain dprint is of really reminding nature, e.g. it temporarily changes behaviour of a certain code path, or shows an unimplemented code path being executed which other code may rely on – then it should obviously stay.

From: Alex Ionescu 
Sent: Thursday, September 08, 2011 11:44 PM
To: ReactOS Development List 
Subject: Re: [ros-dev] [ros-diffs] [fireball] 53635: - Downgrade someDPRINT1s to DPRINTs.

? 

And who decides? This sounds like utter BS!

So while navigating it's okay to get 100000 "UIMPLEMENTED FOR PIDL" or 100 IRP unimplemented messages, but it's wrong to get other dprints?!

Best regards,
Alex Ionescu



On Thu, Sep 8, 2011 at 7:48 PM, Aleksey Bragin <aleksey at reactos.org> wrote:

  That’d be great but it’s important to not "overdo” the job.

  WBR,
  Aleksey.

  From: Alex Ionescu 
  Sent: Thursday, September 08, 2011 9:40 PM
  To: ReactOS Development List 
  Subject: Re: [ros-dev] [ros-diffs] [fireball] 53635: - Downgrade someDPRINT1s to DPRINTs.

  Then why not get rid of ALL similar dprints? 

  Best regards,
  Alex Ionescu



  On Thu, Sep 8, 2011 at 6:34 PM, Aleksey Bragin <aleksey at reactos.org> wrote:

    If someone wants to implement
    1. Alternate resource support
    2. BasePostImportInit and related advanced stuff
    3. Application compatibility hacks support
    he should be at least that smart to see that support for those features is totally non-existant, so there is nothing to warn about.

    It’s similar to having this reminder in the early init stage: DPRINT1(“ReactOS is in alpha stage, some features may be missing. You have been warned!\n”);

    WBR,
    Aleksey Bragin.

    From: Alex Ionescu 
    Sent: Thursday, September 08, 2011 8:39 PM
    To: ros-dev at reactos.org 
    Cc: ros-diffs at reactos.org 
    Subject: Re: [ros-dev] [ros-diffs] [fireball] 53635: - Downgrade someDPRINT1s to DPRINTs.

    For the stuff that was obviously designed to warn at least once, have you filled out bug reports for all these missing features, or do you think that someone will now remember all this missing code? 

    Best regards,
    Alex Ionescu



    On Thu, Sep 8, 2011 at 9:28 AM, <fireball at svn.reactos.org> wrote:

      Author: fireball
      Date: Thu Sep  8 08:28:41 2011
      New Revision: 53635

      URL: http://svn.reactos.org/svn/reactos?rev=53635&view=rev
      Log:
      - Downgrade some DPRINT1s to DPRINTs.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.reactos.org/pipermail/ros-dev/attachments/20110909/f53185d5/attachment.htm>