[ros-dev] [ros-diffs] [dchapyshev] 53516: - Fix typos, found by PVS-Studio

Thomas Faber thfabba at gmx.de
Thu Sep 1 13:28:28 UTC 2011


Hey again,

On 2011-09-01 15:18, dchapyshev at svn.reactos.org wrote:
> --- trunk/reactos/dll/win32/netshell/lanstatusui.c [iso-8859-1] (original)
> +++ trunk/reactos/dll/win32/netshell/lanstatusui.c [iso-8859-1] Thu Sep  1 13:18:22 2011
> @@ -179,7 +179,7 @@
>              pContext->Status = 3;
>          }
>      }
> -    else if (IfEntry.dwOperStatus == MIB_IF_OPER_STATUS_UNREACHABLE || MIB_IF_OPER_STATUS_DISCONNECTED)
> +    else if (IfEntry.dwOperStatus == MIB_IF_OPER_STATUS_UNREACHABLE | MIB_IF_OPER_STATUS_DISCONNECTED)
>      {
>          if (pContext->Status != 4)
>          {
> 

this should more likely be
else if (IfEntry.dwOperStatus == MIB_IF_OPER_STATUS_UNREACHABLE ||
         IfEntry.dwOperStatus == MIB_IF_OPER_STATUS_DISCONNECTED)


Some nice fixes right there by the way. :)
*hopes this might fix some evil bugs that have been lurking* ;)

Thanks,
Tom



More information about the Ros-dev mailing list