[ros-dev] [ros-diffs] [rharabien] 52244: [NTOSKRNL] - Disable displaying string by bootvid after successful kernel phase 1 initialization, so there won't be graphical glitches at the top of screen if system has screen d...

[Alex Ionescu]

To clarify, InbvDisplayString only prints something if the display ownership is owned by INBV.

So it doesn't hurt to leave the enable state to true.

--
Best regards,
Alex Ionescu

On 2011-06-15, at 9:50 AM, Rafał H wrote:

> You are right. I forgot about boot applications.
> Where disabling display string should be then? Is SmLoadSubsystems good place for it?
> 
> Best regards,
> Rafał Harabień
> 
>> How do you expect to see autochk's boot strings if you disabled DisplayString before launching smss?
>> 
>> The correct order is this:
>> 
>> 1) Enable Inbv + Disable Strings
>> 2) re-enable strings if SOS is on
>> 3) Create smss
>> 4) Finalize boot logo
>> 5) Set progressbar to 100%
>> 6) Enable display strings
>> 7) Wait 5 seconds for smss
>> 
>> Also all those DPRINT1s should be KeBugChecks with things like SESSIONX_INITIALIZATION_FAILED, IOX_INITIALIZATION_FAILED, etc....
>> 
>> --
>> Best regards,
>> Alex Ionescu
>> 
>> On 2011-06-15, at 9:12 AM, Rafał H wrote:
>> 
>>>> Or another way of putting this...
>>>> 
>>>> ""Fix" 100% correct reverse engineered NT code and break it so that it matches ReactOS's broken Video Driver Framework behaviour, instead of fixing the latter".
>>>> 
>>>> Never gets old~
>>>> 
>>>> --
>>>> Best regards,
>>>> Alex Ionescu
>>>> 
>>> 
>>> What's wrong? How you want to display strings by bootvid driver which uses VGA, when another 3rd party driver can be loaded? It doesn't make sense.
>>> I don't reverse NT kernel but disabling bootvid functionality when we switch to normal graphics mode make sense for me...
>>> 
>>> Best regards,
>>> Rafal Harabien
>>> 
>>> _______________________________________________
>>> Ros-dev mailing list
>>> Ros-dev at reactos.org
>>> http://www.reactos.org/mailman/listinfo/ros-dev
>> 
>> 
>> _______________________________________________
>> Ros-dev mailing list
>> Ros-dev at reactos.org
>> http://www.reactos.org/mailman/listinfo/ros-dev
> 
> _______________________________________________
> Ros-dev mailing list
> Ros-dev at reactos.org
> http://www.reactos.org/mailman/listinfo/ros-dev