[ros-dev] [PREFIXES] in commit messages still useful?

Aleksey Bragin aleksey at reactos.org
Thu Nov 11 08:27:21 UTC 2010


I also like the prefixes because they provide a quick reference to what module was changed the most in that commit. It's similar to wine's "msi: Implement Blah()". If "msi" would absent, you would need to look into what files were changed, what was the path, and what is the module under that path. Instead, you see it's msi.dll.


WBR,
Aleksey.


From: Zachary Gorden 
Sent: Wednesday, November 10, 2010 8:05 PM
To: ReactOS Development List 
Subject: Re: [ros-dev] [PREFIXES] in commit messages still useful?


Some are useful, some aren't.  I use them as a general guideline for when I put together newsletters and as, tiresome, as parsing through the commit logs was for the past release, the prefixes did help me figure out how commits were related.  Something like [SPRINTF] is a bit too specific.  [RTL] would have been sufficient and more informative.


On Tue, Nov 9, 2010 at 6:34 PM, Edison Henrique Andreassy <ehasis at hotmail.com> wrote:

  Hello,

  I like the those [PREFIXES]. I usually keep looking at cia.vc and monitoring what's happening.

  Regards,
  Henrique

  -----Mensagem Original----- From: Colin Finck
  Sent: Tuesday, November 09, 2010 8:26 PM
  To: ReactOS Development List 

  Subject: [ros-dev] [PREFIXES] in commit messages still useful?


  Hi everyone,

  I'm wondering whether our [PREFIXES] in commit messages are still useful
  as of today?
  If I recall correctly, they were once added to autogenerate a changelog.
  I also remember that this dramatically failed when Ziliang created the
  0.3.12 changelog and the full changelog needed to be redone from
  scratch, manually of course.

  Furthermore, I doubt that prefixes like "[SPRINTF]" (r49512) or faulty
  ones like "{ASM]" (r49413) can still be reasonably associated to a
  changelog category.
  After all, we don't even have a list of valid prefixes, so one has to
  first look at all used ones anyway.

  Of course, I don't want them to be dropped instantly tomorrow, but I'm
  interested in your opinions.
  I also don't yet know about the planned method for creating the 0.3.13
  changelog, so I might be wrong on this.

  Cheers,

  Colin

  _______________________________________________
  Ros-dev mailing list
  Ros-dev at reactos.org
  http://www.reactos.org/mailman/listinfo/ros-dev 

  _______________________________________________
  Ros-dev mailing list
  Ros-dev at reactos.org
  http://www.reactos.org/mailman/listinfo/ros-dev





--------------------------------------------------------------------------------


_______________________________________________
Ros-dev mailing list
Ros-dev at reactos.org
http://www.reactos.org/mailman/listinfo/ros-dev
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.reactos.org/pipermail/ros-dev/attachments/20101111/4c55f080/attachment.htm>


More information about the Ros-dev mailing list