[ros-dev] Re : Removing the autoregister feature from rbuild

[Sylvain Petreolle]

I fully agree on this.
This will also remove the need to rebuild the dll (and possibly other dependant modules)
if we have to disable a registration for testing/debugging purposes.

As I previously said on IRC, we shouldn't expect making coffee from our build system.

 Kind regards,
Sylvain Petreolle


----- Message d'origine ----
> De : Eric Kohl <eric.kohl at t-online.de>
> À : ReactOS Development List <ros-dev at reactos.org>
> Envoyé le : Dim 13 juin 2010, 20h 11min 49s
> Objet : [ros-dev] Removing the autoregister feature from rbuild
> 
> Hi!

I want to remove the "autoregister" feature from rbuild. Let me 
> explain why I want to do this.

The "autoregister" feature in rbuild is 
> used to automatically add dlls to the syssetup.inf file which require an ole 
> server registration. The ole servers in these dlls will then be registered in 
> the 2nd setup stage.

The gain of adding the ole server dlls to 
> syssetup.inf automatically is almost non existant as a developer needs to add an 
> 'autoregister' element to the rbuild file of the dll.
For example:
  
>   <autoregister infsection="OleControlDlls" type="DllInstall" 
> />
The corresponding line in the 'OleControlsDll' section of syssetup.inf 
> is:
    11,,comctl32.dll,2

Please remember that the line 
> above only needs to be added once.

Now, what do we loose by generating 
> syssetup.inf automatically? Right now it is only the comments in this file as it 
> is parsed and serialized by the inflib library.

OTOH, my future plans for 
> syssetup.inf are severely hampered by the way rbuild handles syssetup.inf 
> because rbuild is not able to create or modify a Unicode version of 
> syssetup.inf. But, a Unicode version of syssetup.inf is required in order to 
> replace the hard-coded creation of the start menu and desktop links in 
> syssetup.dll by a configurable, localizable and Windows compatible inf-based 
> method.

And finally since Timo suggested to replace rbuild by cmake: The 
> autoregister feature would surely be one of the victims of this change.
So 
> why not drop this almost useless feature now?

What do you 
> think?


Regards,
Eric

_______________________________________________
Ros-dev 
> mailing list

> href="mailto:Ros-dev at reactos.org">Ros-dev at reactos.org

> href="http://www.reactos.org/mailman/listinfo/ros-dev" target=_blank 
> >http://www.reactos.org/mailman/listinfo/ros-dev