[ros-dev] [ros-diffs] [mkupfer] 39871: Sascha Clausen <r4v3r AT hotmail DOT de> - Draw bullet for menu radio group. - See issue #4193 for details.

[Steven Edwards]

Hi,

On Thu, Mar 5, 2009 at 5:16 AM, Matthias Kupfer <mkupfer at reactos.org> wrote:
> I would like to make clear some things:
> - we generally don't use marlett font for drawing gui elements in draw.c
> - I asked some years ago to do this that way (with marlett or even prepared
> bitmaps) and it was rejected by several devs
> - It's not the radio button element, the function is similar to radio button,
> but the element looks different (marlett may contain it nevertheless)
>
> So we can change all elements step by step even in draw.c and elsewhere...

Sorry for being so late bringing this up. I was wondering why you did
not start by importing the latest Wine code for the menus and then
from there start your development. I ask because I am curious if your
new code passes the regression tests. We were using a very old
implementation based off winehq from what 2002? I am sure it had its
share of bugs and I agree the current Winehq implementation still only
uses marlett in one place so its not the 'correct' solution but I know
as far as compatibility goes its currently pretty good.

Anyway it just seems to me that having the tests pass as close to 100%
is the most important thing so starting from a known stable point
seems like it would be a better method, but I admit I've not looked at
either your implementation or the Wine code in depth and I understand
your aiming for the most technically correct solution.

Thanks
-- 
Steven Edwards

"There is one thing stronger than all the armies in the world, and
that is an idea whose time has come." - Victor Hugo