[ros-dev] [ros-diffs] [dchapyshev] 41755: - Fixes return values for PeekMessageA/W

Steven Edwards winehacker at gmail.com
Sun Jul 5 01:32:47 CEST 2009


On Fri, Jul 3, 2009 at 5:53 AM, <dchapyshev at svn.reactos.org> wrote:
> -  if (-1 == (int) Res || ! Res)
> -    {
> -      return Res;
> +  if (-1 == (int) Res || !Res)
> +    {
> +      return FALSE;

I know you didn't write the check and were just changing the return
values but as a matter of style could we do something like

if (((int) Res || !Res) == -1)

or would the extra parens mess up the order of operations? Not a big
deal, its just easier on my eyes.

Thanks
-- 
Steven Edwards

"There is one thing stronger than all the armies in the world, and
that is an idea whose time has come." - Victor Hugo



More information about the Ros-dev mailing list