[ros-dev] [ros-diffs] [cfinck] 44368: [General] - Remove the "kernel32" library reference in all .rbuild files of user-mode modules, because this one is already added by "mingw_common". Also fix the indentation in some files.

[Timo Kreuzer]

KJK::Hyperion schrieb:
> Alex Ionescu wrote:
>   
>> Why can't rbuild do something sensible like MSVC does, and
>> automatically import the core win32 libraries if the project type is
>> "Win32 binary", unless someone uses $(NO_INHERIT) and/or
>> /NODEFAULTLIBS ?!?
>>     
>
> Because I have not implemented it yet
>   
And I don't see any merit in it. It just adds more complexity to rbuild.
Then it needs to know about module types and standard libraries.
That's not the job of a build system imo.
Just put all the damn libraries into the rbuild file and all is well. It
makes everyone reading the file know what is linked and also we avoid
shit being linked that we don't want to link to, as we had multiple
times in the past. May I remind of win32k linking to ntdll....

Just my 2 cents,
Timo