[ros-dev] [ros-diffs] [sginsberg] 42973: - %llx -> %I64x - Don't pass a string literal to strcmp

[Timo Kreuzer]

Huh? Why shouldn't one use a string literal in strcmp? What are you
trying to "fix"?

sginsberg at svn.reactos.org wrote:
> Author: sginsberg
> Date: Sun Aug 30 20:40:58 2009
> New Revision: 42973
>
> URL: http://svn.reactos.org/svn/reactos?rev=42973&view=rev
> Log:
> - %llx -> %I64x
> - Don't pass a string literal to strcmp
>
> Modified:
>     trunk/rosapps/applications/devutils/symdump/symdump.c
>     trunk/rosapps/applications/devutils/syscalldump/syscalldump.c
>     trunk/rosapps/applications/sysutils/systeminfo/systeminfo.c
>
> Modified: trunk/rosapps/applications/devutils/symdump/symdump.c
> URL: http://svn.reactos.org/svn/reactos/trunk/rosapps/applications/devutils/symdump/symdump.c?rev=42973&r1=42972&r2=42973&view=diff
> ==============================================================================
> --- trunk/rosapps/applications/devutils/symdump/symdump.c [iso-8859-1] (original)
> +++ trunk/rosapps/applications/devutils/symdump/symdump.c [iso-8859-1] Sun Aug 30 20:40:58 2009
> @@ -875,7 +875,7 @@
>  		}
>  		else
>  		{
> -		    printf("Symbol: %s, TypeIndex=%ld, Flags=%lx, Value=0x%llx\n",
> +		    printf("Symbol: %s, TypeIndex=%ld, Flags=%lx, Value=0x%I64x\n",
>  		        pSymInfo->Name, pSymInfo->TypeIndex, pSymInfo->Flags, pSymInfo->Value);
>  			//if (pSymInfo->Flags & SYMFLAG_FUNCTION)
>  			{
>
> Modified: trunk/rosapps/applications/devutils/syscalldump/syscalldump.c
> URL: http://svn.reactos.org/svn/reactos/trunk/rosapps/applications/devutils/syscalldump/syscalldump.c?rev=42973&r1=42972&r2=42973&view=diff
> ==============================================================================
> --- trunk/rosapps/applications/devutils/syscalldump/syscalldump.c [iso-8859-1] (original)
> +++ trunk/rosapps/applications/devutils/syscalldump/syscalldump.c [iso-8859-1] Sun Aug 30 20:40:58 2009
> @@ -36,7 +36,7 @@
>  		printf("SymGetSymFromName64() failed: %ld\n", GetLastError());
>  		return 0;
>  	}
> -	printf("looking up adress for %s: 0x%llx\n", Name, pSym->Address);
> +	printf("looking up adress for %s: 0x%I64x\n", Name, pSym->Address);
>  
>  	NtHeaders = ImageNtHeader(pModule);
>  	p = ImageRvaToVa(NtHeaders, pModule, pSym->Address - pSym->ModBase, NULL);
>
> Modified: trunk/rosapps/applications/sysutils/systeminfo/systeminfo.c
> URL: http://svn.reactos.org/svn/reactos/trunk/rosapps/applications/sysutils/systeminfo/systeminfo.c?rev=42973&r1=42972&r2=42973&view=diff
> ==============================================================================
> --- trunk/rosapps/applications/sysutils/systeminfo/systeminfo.c [iso-8859-1] (original)
> +++ trunk/rosapps/applications/sysutils/systeminfo/systeminfo.c [iso-8859-1] Sun Aug 30 20:40:58 2009
> @@ -358,7 +358,8 @@
>  int
>  main(int argc, char *argv[])
>  {
> -	if (argc > 1 && !strcmp(argv[1], "/?"))
> +    char str[] = "/?";
> +	if (argc > 1 && !strcmp(argv[1], str))
>  	{
>  		Usage();
>  		return 0;
>
>
>
>