[ros-dev] [ros-diffs] [cfinck] 33824: - Add a test suite forws2_32.dll It currently tests the features I needed toadjust/implement when fixing the wininet problem. ReactOScurrently passes all tests, but fails one if you launch the test app for th

[Steven Edwards]

On Tue, Jun 3, 2008 at 5:08 PM, Colin Finck <mail at colinfinck.de> wrote:
> The Wine test framework is currently only used by tests imported from Wine,
> so an own test suite for ws2_32.dll might get lost there.

You could have written the tests for the wine test suite and submitted them.

> Also Timo's testing framework offers some interesting features like HTML
> output not offered by the Wine one.

Sure, but given the size of the wine test suite verses Timo's I think
the effort is
better spent adding this to winetest

> Additionally, we have a free hand here and can play with it as we want,
> while we can only import and maybe make little changes to the Wine test
> framework if we want to avoid a big merging mess.

Your always free to fork. As I said given the large number of unit
tests in the Wine framework
it seems to make more sense to me to extend that rather than develop a new one.
Besides you can add the features you need to the Winetest gui and have
it be independent
of the framework as a whole.

-- 
Steven Edwards

"There is one thing stronger than all the armies in the world, and
that is an idea whose time has come." - Victor Hugo