[ros-dev] [ros-diffs] [sginsberg] 35819: - CACHE_DESCRIPTOR and PROCESSOR_CACHE_TYPE are public and defined in winnt.h, so no need to define them in the NDK (the NDK includes winnt.h through windef.h, so this breaks build)

[Alex Ionescu]

Did you purposedly completely ignore what I wrote?

Best regards,
Alex Ionescu



On Sun, Aug 31, 2008 at 10:14 AM, Aleksey Bragin <aleksey at reactos.org> wrote:
> They are in 6001/inc/api/winnt.h.
>
>
> WBR,
> Aleksey Bragin.
> On Aug 31, 2008, at 3:00 AM, Alex Ionescu wrote:
>
>> Please make sure that these types are available for DRIVERS as well --
>> otherwise, they belong in the NDK. (Check with WDK
>> wdm.h/ntddk.h/ntifs.h -- if it's not there, and drivers can access
>> pointers/structures of this type, it must be in the NDK).
>>
>> Also, the NDK does not include winnt.h -- at least it's not supposed
>> to, unless someone broke it.
>>
>> For the future, please make suer to review NDK changes with me, since
>> I'm still its owner.
>>
>> Best regards,
>> Alex Ionescu
>>
>>
>>
>> On Sat, Aug 30, 2008 at 11:34 PM,  <sginsberg at svn.reactos.org> wrote:
>>> Author: sginsberg
>>> Date: Sat Aug 30 16:34:56 2008
>>> New Revision: 35819
>>>
>>> URL: http://svn.reactos.org/svn/reactos?rev=35819&view=rev
>>> Log:
>>> - CACHE_DESCRIPTOR and PROCESSOR_CACHE_TYPE are public and defined
>>> in winnt.h, so no need to define them in the NDK (the NDK includes
>>> winnt.h through windef.h, so this breaks build)
>>>
>>> Modified:
>>>    trunk/reactos/include/ndk/ketypes.h
>>>
>>> Modified: trunk/reactos/include/ndk/ketypes.h
>>> URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/ndk/
>>> ketypes.h?rev=35819&r1=35818&r2=35819&view=diff
>>> =====================================================================
>>> =========
>>> --- trunk/reactos/include/ndk/ketypes.h [iso-8859-1] (original)
>>> +++ trunk/reactos/include/ndk/ketypes.h [iso-8859-1] Sat Aug 30
>>> 16:34:56 2008
>>> @@ -542,17 +542,6 @@
>>>  } KAPC_ENVIRONMENT;
>>>
>>>  //
>>> -// CPU Cache Types
>>> -//
>>> -typedef enum _PROCESSOR_CACHE_TYPE
>>> -{
>>> -    CacheUnified,
>>> -    CacheInstruction,
>>> -    CacheData,
>>> -    CacheTrace,
>>> -} PROCESSOR_CACHE_TYPE;
>>> -
>>> -//
>>>  // PRCB DPC Data
>>>  //
>>>  typedef struct _KDPC_DATA
>>> @@ -571,18 +560,6 @@
>>>     struct _GENERAL_LOOKASIDE *P;
>>>     struct _GENERAL_LOOKASIDE *L;
>>>  } PP_LOOKASIDE_LIST, *PPP_LOOKASIDE_LIST;
>>> -
>>> -//
>>> -// CPU Cache Descriptor
>>> -//
>>> -typedef struct _CACHE_DESCRIPTOR
>>> -{
>>> -    UCHAR Level;
>>> -    UCHAR Associativity;
>>> -    USHORT LineSize;
>>> -    ULONG Size;
>>> -    PROCESSOR_CACHE_TYPE Type;
>>> -} CACHE_DESCRIPTOR, *PCACHE_DESCRIPTOR;
>>>
>>>  //
>>>  // Architectural Types
>>>
>>>
>> _______________________________________________
>> Ros-dev mailing list
>> Ros-dev at reactos.org
>> http://www.reactos.org/mailman/listinfo/ros-dev
>
> _______________________________________________
> Ros-dev mailing list
> Ros-dev at reactos.org
> http://www.reactos.org/mailman/listinfo/ros-dev
>