[ros-dev] [ros-diffs] [sginsberg] 35600: - Remove KEBUGCHECK and KEBUGCHECKEX macros - Replace "KeBugCheck(0)" by ASSERT(FALSE) - Replace deprecated "CPRINT" by DRINT1

[Hervé Poussineau]

sginsberg at svn.reactos.org a écrit :
> Author: sginsberg
> Date: Sun Aug 24 10:48:05 2008
> New Revision: 35600
> 
> URL: http://svn.reactos.org/svn/reactos?rev=35600&view=rev
> Log:
> - Remove KEBUGCHECK and KEBUGCHECKEX macros
> - Replace "KeBugCheck(0)" by ASSERT(FALSE)
> - Replace deprecated "CPRINT" by DRINT1
> 

You probably understand that KEBUGCHECK(0) is *NOT* the same as 
ASSERT(FALSE)

ASSERT(FALSE) is valid only in debug mode, and lets the code continue in 
release mode.
KEBUGCHECK stops the execution also in release mode.

For example, in ntoskrnl/dbgk/dbgkobj.c, code now continues even if 
DbgkpQueueMessage failed. Are you sure it is safe to continue in that case?
(same question applies for other locations)

Hervé