[ros-dev] [ros-diffs] [tretiakov] 25758: Add multiple keyboard layout support. Implemented NtUserLoadKeyboardLayoutEx, NtUserActivateKeyboardLayout, NtUserGetKeyboardLayoutList, NtUserGetKeyboardLayoutName.

[James Tabor]

Hi!
Saveliy Tretiakov wrote:
> Aleksey Bragin пишет:
> 
>>Magnus says that this change is incorrect (and respective change of  
>>the prototype is incorrect too, because, he says, we had a Win2003- 
>>compatible prototype). Can you comment on this please
>>  
> 
> NtUserLoadKeybardLayoutEx is not documented and no application calls it 
> directly, thus we have freedom to modify it.
> We don't need to do everything same way windows does. I was talking with 
> James Tabor about it and we decided to do it different way.
> 
Yes, I did tell you to optimize and make it efficient.

Remember the basic idea of the project! Equal or better than m$!

> Six params are not needed. I can restore old header back, but 4 
> parameters will stay unused forever and waste memory.
> 
It's okay to have the wasted space. We can use the Handle arg to let us
know if it is a m$ user32.dll is calling. Handle != NULL is ROS.

Good job on the patch!
Thanks,
James