[ros-dev] [ros-diffs] [cfinck] 28423: - Alwaysinclude"wine/unicode.h" before all other headers, when we need the wchar_t type. unicode.h includes windef.h, which includes winnt.h, which has the handling for the wchar_t type. As it's the firstinc

[Colin Finck]

> On 8/19/07, Steven Edwards wrote:
> It makes anyone doing a diff have more stuff to have to workaround.

Agreed, so we should come to a common solution with Wine.


> I guess its using a define in the makefile for _WCHAR_T generated by
> configure or something.

Might be possible, but I don't see this as a good solution.
As Ged already mentioned, I also changed this in wrc and other components.

If you look in glibc's "stddef.h" (for example here:
http://tinyurl.com/yv6s9b), you find 32 checks for the existence of the
wchar_t type.
We'll probably never need all of them, but this just shows that almost every
host needs its own check.
And adding all these definitions to the Makefile of every app, which needs
them, is a huge overkill in my opinion. This is why I prefer putting all
checks into "winnt.h".

I don't want to sound harsh here, but couldn't maybe Wine adapt our solution
as well?

Regards,

Colin