[ros-dev] [ros-diffs] [greatlrd] 28055: user32 cleanup lite redirect the InvalidateRect at 12 to NtUserInvalidateRect at 12 in the def file nci tools changes (done of timo and me) frist part moving the w32ksvc.db and sysfuncs.lst where they belong

[Thomas Weidenmueller]

No it's not worth the hazzle because those changes result in *NO*
optimizations anyway. The code that was changed were calls to
InvalidateRect to NtUserInvalidateRect. Since InvalidateRect is already
forwarded to NtUserInvalidateRect this doesn't really improve anything,
it's the same overhead. These changes should be reverted, not just
because it makes no sense to optimize these function calls even more
because they're absolutely not time-critical.

Please revert.

- Thomas

Steven Edwards wrote:
> On 7/31/07, greatlrd at svn.reactos.org <greatlrd at svn.reactos.org> wrote:
>> user32 cleanup lite
>> redirect the InvalidateRect at 12 to NtUserInvalidateRect at 12 in the def file
> 
>> Modified:
>>     trunk/reactos/dll/win32/user32/controls/button.c
>>     trunk/reactos/dll/win32/user32/controls/combo.c
> 
> Is it really worth the merge hassle to change it in these two files?
> They are almost 100% shared with Wine and I doubt the overhead in
> calling InvalidateRect vs NtUserInvalidateRect is worth the hassle on
> whoever the maintainer is going to be....
>