[ros-dev] Re: [ros-diffs] [amunger] 21474: DHCP Client fixes and enhancements Set the correct hardware type flag. Fixes bug 651. Send option 12 on discovery, allows some DHCP servers to dynamically update DNS. Send option 61 for good measure. We

[Thomas Weidenmueller]

WaxDragon wrote:
> I really tire of hearing this.  None of the code in dhcp.exe is
> unicode right now.  I've tried to hack on several pieces of ros only
> to be told "USE UNICODE" by another dev.  Trying to convert entire
> modules has always gone terribly for me.

I'm sorry. I didn't look at the other code. I only looked at the diff.
Anyway, I'm not blaming you, we got tons of terrible code, so I tend to
point them out when it makes sense. Especially when something crashes
for me ;)

I don't mean to offend anybody with my criticism, I just want to point
out what could and should be fixed or done differently. Sooner or later
this project needs to focus on security, so all these things have to be
fixed some day. It might not be soon, but I think we should try to keep
the number of obvious bugs in code we add as small as possible. I
realize that probably 90% of dhcp is very poor quality, but once again,
I only looked at the patch.

- Thomas