[ros-dev] Re: [ros-svn][gdalsnes]18113:-reorderInsertXscendingOrder macro argument orderand update uses

[Casper Hornstrup]

> -----Original Message-----
> From: ros-dev-bounces at reactos.com [mailto:ros-dev-bounces at reactos.com] On Behalf Of Alex Ionescu
> Sent: 29. september 2005 19:02
> To: ReactOS Development List
> Subject: Re: [ros-dev] Re: [ros-svn][gdalsnes]18113:-reorderInsertXscendingOrder macro argument
> orderand update uses
> 
> Go ahead and have your vote, but I'm simply going to overwrite their
> usage in my code when I commit new stuff.
> You can't go ahead, piss on someone's code, and then have a vote if the
> person that got pissed on should get his code back or not. What kind of
> screwed up system is that? Go count the threads itself, I've counted 15
> people who agreed that:
> 
> 1) Macros are bad, especially in ntoskrnl
> 2) Overwriting someone's maintained code is bad.
> 

Voting is the best decision making procedure we've found so far.
Overwriting someone else's code just because you don't like it is counter
productive. If there are arguments for not implementing something in a
particular way then provide those arguments, vote on the subject, and
document the result in wiki. Whenever you remove code that violates a rule
in the future, you only need to reference the relevant section in wiki to
have the "right" to remove the code. There is no need to fight over which
code is "best" or which code is more "right". The rule is in wiki and it
applies until replaced by a new rule. If there is no formal rule, then
there is nothing stopping another developer from replacing your replaced
code. This could go on forever or until all developers, but one give up,
wasting a lot of the (already limited) resources of the project.

> Regardless of the outcome of this "vote", the 4 files that I wrote
> 99.99% of will be returned to their original state by me, it's my right.

ReactOS has collective code ownership. This implies that all developers own
all code and you have no more right to change a piece of code than anyone
else which is taking part of the project. If you want to see module ownership
instead then propose a solution for this and call for a vote on the
subject.

Casper