[ros-dev] Re: [ros-svn] [gdalsnes]18113:-reorderInsertXscendingOrder macro argument order and update uses

Gunnar Dalsnes hardon at online.no
Wed Sep 28 23:44:31 CEST 2005

Phillip Susi wrote:

> To try and steer this back to the original issue, the LIST_FOR_EACH 
> macro causes nonintuitive branching which is hard to understand when you 
> read it

Lerning it is well worth the effort.

> and when working on the code, as Alex said, you often have to 
> demacrofy it which can introduce more errors.  

This is the only valid point and to my defence i have said that some of 
the loops i replaced were for loops and here he would have exactly the 
same problem.

> These are legitimate down 
> sides to using the macro, so again, you need a good reason to use it.
> So far you seem to only keep insisting that the macros look better to 
> you, so I say again, pleasing your sense of aesthetics does not outweigh 
> the loss of maintainability.

As said before, there really isnt a way to maintain walking a list. This 
is code printed in stone.



More information about the Ros-dev mailing list