[ros-dev] Re: [ros-diffs] [ion] 18082: - Fix a bug in CSR Capture APIs

Alex Ionescu ionucu at videotron.ca
Mon Sep 26 19:39:50 CEST 2005

Thomas Weidenmueller wrote:

>ion at svn.reactos.com wrote:
>>+  CsrCaptureMessageBuffer(CaptureBuffer,
>>+                          NULL,
>>+                          Size,
>>+                          (PVOID*)&Request.Data.PeekConsoleInputRequest.InputRecord);
>The last parameter passed to CsrCaptureMessageBuffer in your changes
>looks horribly wrong. The typecast hides the bug and shouldn't be
>necessary, the compiler would've warned you that this is most likely wrong.
>- Thomas

Shoot first, ask questions later ;-).

At least someone reviews patches!

Best regards,
Alex Ionescu

More information about the Ros-dev mailing list