[ros-dev] Re: [ros-diffs] [ion] 19742: - Implement RtlPrefectMemoryNonTemporal. Patch by Patrick Baggett <baggett.patrick@gmail.com> and myself.

Thomas Weidenmueller w3seek at reactos.com
Tue Nov 29 10:33:32 CET 2005


ion at svn.reactos.com wrote:
> - Implement RtlPrefectMemoryNonTemporal. Patch by Patrick Baggett <baggett.patrick at gmail.com> and myself.
> ------------------------------------------------------------------------
> *Modified: trunk/reactos/lib/rtl/mem.c*
> 
> --- trunk/reactos/lib/rtl/mem.c	2005-11-29 01:54:33 UTC (rev 19741)
> +++ trunk/reactos/lib/rtl/mem.c	2005-11-29 02:40:18 UTC (rev 19742)
> @@ -140,7 +140,7 @@
> 
>  }
>  
>  /*
> 
> -* @unimplemented
> 
> +* @implemented
> 
>  */
>  VOID
>  FASTCALL
> @@ -149,7 +149,9 @@
> 
>  	IN SIZE_T Length
>  	)
>  {
> 
> -	UNIMPLEMENTED;
> 
> +	/* By nature of prefetch, this is non-portable. */
> +	(void)Source;
> +	(void)Length;
> 
>  }
>  
>  
> 

Why have a function stub then? This just encourages someone to use it
without #ifdef'ing it when porting to another platform.

- Thomas


More information about the Ros-dev mailing list