[ros-dev] RE: [ros-diffs] [cwittich] 19320: got a lot of crypt32stuff working

[Robert Shearman]

Magnus Olsen wrote:

>The problem is wine does not accpect some patch
>

That is usually for technical reasons (like the extra header includes 
proposed by Thomas that were needed because of the ReactOS exception 
handlers).

>and some other patch is
>reactos spefic
>

Then you find a way of minimizing the scope of the patch, e.g. by 
putting ReactOS only functionality in another file and adding a line or 
two to hook into this file. We also try to do the same in Wine, e.g. for 
the Shell UnixFS.

>and some other is for both windows and reactos but it will
>break wine.
>

Then you could try to fix the problem, or else describe the problem 
enough so that a Wine developer can fix it. For instance, GvG proposed 
that we change the way statuses are defined in our Wine to be compatible 
with ReactOS and the Platform SDK by causing a compile failure when 
including both winnt.h and ntstatus.h.

Sweeping problems under the carpet, especially without understanding why 
they are happening doesn't improve either project.

-- 
Rob Shearman