[ros-dev] RE: [ros-diffs] [cwittich] 19254: add a check forSPDRP_CONFIGFLAGSwhich is not working yet

[Casper Hornstrup]

> -----Original Message-----
> From: ros-dev-bounces at reactos.org [mailto:ros-dev-bounces at reactos.org] On Behalf Of Alex Ionescu
> Sent: 15. november 2005 21:36
> To: ReactOS Development List
> Subject: Re: [ros-dev] RE: [ros-diffs] [cwittich] 19254: add a check forSPDRP_CONFIGFLAGSwhich is
> not working yet
> 
> While your points are valid, newdev is his baby and he should be allowed
> to do with it as he damn well pleases. Don't tell me you've never done
> this kind of operation locally on your disk? Christopher just chose to
> commit it. It's why I now run a local branch and only commit final code;
> it lets me do what I want with code that I wrote 100% of, without being
> criticzed about design choices before the application is complete.
> 
> Note: If this wasn't his app or was a really old app we depend on, I
> would agree with you. But as far as I'm concerned this is his
> application and for now there's no point in reviewing it until he
> considers it done and ready for review.
> 
> Best regards,
> Alex Ionescu

No way. Contributing something doesn't give you any more right over it than
anyone else in the community (except copyright). If someone can't accept that,
then they shouldn't contribute to a community effort like ReactOS. If newdev
is Christopher's "baby", then ntoskrnl must be David's "baby". So what were
you doing in David's code?

I'm sorry to hear that you believe that reviewing is just about critiquing
someones work and that you are obviously so afraid to answer questions about
your code that you choose to keep it a secret for as long as possible and
commit it in big batches.

There is very much a point in reviewing as early as possible. It is to find
bugs as early as possible.

Casper