[ros-dev] NPFS problems

[Alex Ionescu]

Casper Hornstrup wrote:

>  
>
>>-----Original Message-----
>>From: ros-dev-bounces at reactos.org [mailto:ros-dev-bounces at reactos.org] On Behalf Of Hartmut Birr
>>Sent: 4. november 2005 21:03
>>To: ReactOS Development List
>>Subject: Re: [ros-dev] NPFS problems
>>
>>Thomas Weidenmueller wrote:
>>    
>>
>>>Casper Hornstrup wrote:
>>>
>>>      
>>>
>>>>You don't think the changes should be reverted?
>>>>
>>>>        
>>>>
>>>As I said it's ok to revert them, but the changes are correct. Our npfs
>>>is the problem and needs to be fixed. Unfortunately I'm not really
>>>familiar with our npfs code, otherwise I would've taken a look at it and
>>>fixed it in the first place. Herve is about to revert the changes for now ;)
>>>
>>>- Thomas
>>>_______________________________________________
>>>
>>>      
>>>
>>Thomas's changes are correct. The problem is the special mode in npfs,
>>which I've removed. The special mode was triggered by opening or
>>creating a pipe with the share disposition read and write. This is
>>wrong. I think, the special mode must be triggered, if the pipe is only
>>open for read attributes.
>>
>>- Hartmut
>>    
>>
>
>I'm sure they are, but I'm also sure that many would prefer "incorrect-and-working"
>over "correct-and-non-working" if those were the only two choices.
>
>Casper
>
>  
>
I wouldn't.

"incorrect-and-working" leads to stuff never being made correct.

Best regards,
Alex Ionescu