[ros-dev] More RBuild issues...

[Casper Hornstrup]

> -----Original Message-----
> From: ros-dev-bounces at reactos.com [mailto:ros-dev-bounces at reactos.com] On Behalf Of Alex Ionescu
> Sent: 29. maj 2005 16:53
> To: ReactOS Development List
> Subject: Re: [ros-dev] More RBuild issues...
> 
> Casper Hornstrup wrote:
> 
> >
> >
> >>-----Original Message-----
> >>From: ros-dev-bounces at reactos.com [mailto:ros-dev-bounces at reactos.com] On Behalf Of Alex Ionescu
> >>Sent: 29. maj 2005 01:40
> >>To: ReactOS Development List
> >>Subject: [ros-dev] More RBuild issues...
> >>
> I did not break anything, I merely fixed what was already broken. You
> merged a crippled build system which could not build optimizations,
> which is something we've done for ages. And I wasted my developer time
> to fix that. I've already told you that I cannot boot the DBG = 1 build
> either, so it has nothing to do with optimizations.

It may be crippled without optimizations but it is hardly anything that
will kill anyone so I decided it was better to merge it to trunk now (and
add support for optimization later) since I could find some time
to merge this weekend. We've hacked on the old build system for 3-4 years
now. It would be impossible for me to implement all features of the old
build system (nor would we want to IMHO).

If we didn't have so many build tool configurations then I didn't have to
make sure it would work in so many configurations. I really wish we had a
standard build tool configuration. If we use the same configuration then
there is a much higher chance it will work for all. If you had told me
it didn't work in your particular configuration within the last 5 months
then I would have made sure it would work if I could.

> If anyone has the right to be annoyed, it's the developers, who since
> yesterday, have been:
> 
> 1) Fixing rbuild bugs (unrelated to optimizations)

I would like it if you could post revision numbers of these bugfixes because
you make it sound like there are a million of them. I know that 'make install'
installs some files to the wrong folders and some files are not installed.
Please list the rest of the issues you believe are bugs. The patch is 2MB and
very intrusive so I don't think you can reasonably expect there to not be
any bugs.

> 2) Unable to boot ROS

You haven't even posted your configuration yet. Do you think I'm psychic?

> 3) Fixing GCC 4.0 bugs.

Since when is there a rule that says you must test your changes with GCC 4?

> 
> I know a minority have these issues, but a minority had GDB bugs too
> when I broke it. And I took responsability for that. You can't outright
> REMOVE features and then say "well Alex, it's your fault for adding them
> back!".

I would have implemented it after the merge.

> Let's not mention the fact that almost all my release features have been
> outright removed from rbuild, as if my work on them didn't even matter.

Why didn't you say which features you wanted ported?

Casper