[ros-dev] Shouldn't errors be explained a bit better?

Reuben Perelman reub2000 at earthlink.net
Tue Aug 30 00:51:48 CEST 2005


I was looking through the installer, and noticed that it generated an 
error for partitions created by linux fdisk. Shouldn't the user be 
informed about this, so they know why. This type of information will 
help a user solve the problem that caused the error.

Below is the code for the error I'm talking about.
 if (WarnLinuxPartitions == TRUE &&
     CheckForLinuxFdiskPartitions (PartitionList) == TRUE)
   {
     PopupError ("Setup found that at least one harddisk contains an 
incompatible\n"
          "partition table that can not be handled properly!\n"
          "\n"
          "Creating or deleting partitions can destroy the partiton 
table.\n"
          "\n"
          "  \x07  Press F3 to quit Setup."
          "  \x07  Press ENTER to continue.",
          "F3= Quit  ENTER = Continue");
     while (TRUE)
    {
      ConInKey (Ir);

      if ((Ir->Event.KeyEvent.uChar.AsciiChar == 0x00) &&
          (Ir->Event.KeyEvent.wVirtualKeyCode == VK_F3)) /* F3 */
        {
          return QUIT_PAGE;
        }
      else if (Ir->Event.KeyEvent.wVirtualKeyCode == VK_RETURN) /* ENTER */
        {
          WarnLinuxPartitions = FALSE;
          return SELECT_PARTITION_PAGE;
        }
    }
   }


More information about the Ros-dev mailing list