[ros-dev] Re: [ea] 17396: CABMAN: add support for optional files (they are listed in the reactos.dff, but may not exist in the output-??? directory).

[Sylvain Petreolle]

It seems you missed a test into your dfp.cxx change.

The change of the series of if() else if() into a switch(){} is ok,
except now it always returns CAB_STATUS_SUCCESS.

+    case CAB_STATUS_NOMEMORY:
+        printf("Insufficient memory to add file: %s.\n", SrcName);
+        break;
+    default:
+        printf("Cannot add file: %s (%lu).\n", SrcName, Status);
+        break;
     }
-
     return CAB_STATUS_SUCCESS;
 }

To restore the correct behaviour, you have to
     return Status;

Kind regards,

Usurp (aka Sylvain Petreolle)

humans are like computers,
yesterday the BIOS was all
- today its just a word