[ros-dev] End-of-merge for some components shared with Wine

[Ge van Geldorp]

> From: Steven Edwards
>
> - tools/widl
> Eric has said he would merge this at some point.

And I'll be happy to include it again in the monthly merges when this has
been done.

> From: Alex Ionescu
>
> I've never liked the policy of "if you want WINE changes, we 
> spend time and make ROS accept them. If WINE wants ROS 
> changes, we spend time and make WINE accept them".

For the WIDL work, Mike McCormack (one of the Wine guys) did step up and
offer help. However, when we're unable to answer questions like:

> For example, why are SHORT and USHORT treated as equal in
tools/widl/client.c?
>
> +                case RPC_FC_USHORT:
> +                case RPC_FC_SHORT:
> +                    print_client("0x4e,    /* FC_IN_PARAM_BASETYPE
*/\n");
> +                    print_client("0x%02x,    /* FC_USHORT */\n", 
> RPC_FC_SHORT);
> +                    break;
> +                case RPC_FC_ULONG:
> +                case RPC_FC_LONG:
> +                    print_client("0x4e,    /* FC_IN_PARAM_BASETYPE
*/\n");
> +                    print_client("0x%02x,    /* FC_LONG */\n", 
> RPC_FC_LONG);
> +                    break;

the patch is not going to be accepted. Now, I have no idea what the above
code fragment is supposed to do, but my experience is that when technical
issues are raised about patches they are usually right.

> From: James Tabor
>
> - lib/winmm
> It never been synced.

Bzzzt, wrong answer. Check svn log.

Gé van Geldorp.