[ros-dev] Caution, Wine Tests maybe Wrong!

[James Tabor]

Hi!
Alex Ionescu wrote:
> Rob Shearman wrote:
> 
>> Alex Ionescu wrote:
>>
>>> Rob Shearman wrote:
>>>
>>>> James Tabor wrote:
>>>>
>>>>>>
>>>>>> The test passes correctly on Windows, so it can't be wrong:
>>>>>> rtl: 600111 tests executed, 0 marked as todo, 0 failures.
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>> I know, that is a problem.
>>>>
>>>>
>>>>
>>>>
>>>>
>>>>
>>>> P.S. As the original author of both Wine's handle table code and the 
>>>> corresponding test code, I find your sarcastic comment somewhat 
>>>> insulting.
>>>
Did not know that.
>>>
>>>
>>>
>>> Pardon me, but how does James' comment stating that the WINE test 
>>> working on Windows but not on ReactOS is a problem become sarcastic 
>>> and insulting? If anything, it was commending WINE on the quality of 
>>> its test.
>>
>>
>>
>>
>> The title of this thread is "Caution, Wine Tests maybe Wrong!". I 
>> therefore took the line "B^| Wow, -what- -a- -sur- -prise-." to mean 
>> that James thinks that Wine has gets things like this wrong on a 
>> regular basis (and incidentally, I don't dispute this, just the manner 
>> in which it was said). I apologise if I got the wrong end of the stick 
>> on this one.
> 
No you did not, end of the Stick, no. Don't forget I said "maybe wrong".
I work for Ros, not Wine so I don't know.

Yes, Caution is needed! I'm not just testing one thing at a time. I test
multiple applications at the same time. Including wine tests. Most of the
time they cause bug checks, and kill the system. So "Caution" is the word.

You did answer one question, there are no structures compatible to work
from.

> 
> Ah, sorry, I didn't even see that comment. I don't even agree that WINE 
> gets things wrong on a regular basis, at least not in this context. Your 
> structure is "wrong" in a way that doesn't influence external behaviour 
> at all. I guess the nice way of saying it would've been "Wow, what a 
> surprise, WINE doesn't need to clone internal structures!" which, 
> although sarcastic, is a lot more factual and is more a pun towards 
> ReactOS ;)
> 

Yeah, is there a standard structure we can use together? This was one of
my grips about using Wine Dll's. What if these structures propagated beyond
kernel32 and are used in comdlg or comctrl? This could fu everything!

Blank,
James