[ros-dev] Caution, Wine Tests maybe Wrong!

[Rob Shearman]

James Tabor wrote:

> Filip Navara wrote:
>
>> Alex Ionescu wrote:
>>
>>> James Tabor wrote:
>>>
>>>> Hi all,
>>>> When running ntdll_test or ntdll_crosstest with rtl selected, it 
>>>> will fail at
>>>> the last test, test_HandleTables. Right at first I checked the wine 
>>>> headers and
>>>> noticed the handle table structures are not the same as ros.
>>>>
>>>> B^| Wow, -what- -a- -sur- -prise-.
>>>>
>>>> Convert tests to Ros? 8^>
>>>
>>>
>>> When I asked Thomas to re-write the handle table implementation I 
>>> remember that the WINE code was wrong and using incorrect 
>>> structures, so I can confirm that their tests will incorrectly fail.
>>
>>
>> The test passes correctly on Windows, so it can't be wrong:
>> rtl: 600111 tests executed, 0 marked as todo, 0 failures.
>
> I know, that is a problem.


Is this an acknowledgement that the test is indeed correct? If not, what 
do you want changed in the test? The RtlpMakeHandleAllocated part is 
deliberate and not merely an implementation detail since I have observed 
Windows components outside of NtDll needing this.

Thanks,
Rob

P.S. As the original author of both Wine's handle table code and the 
corresponding test code, I find your sarcastic comment somewhat insulting.