[ros-dev] ASSERT_IRQL and unrelated mm/mdl.c

[Hartmut Birr]

Hi,    

there is still another bug in MmProbeAndLockPages. It is always locked the
address space of the current process, even if the address is located within
the kernel address space. In this case it must lock the kernel address
space.   

- Hartmut

> -----Original Message-----
> From: ros-dev-bounces at reactos.com 
> [mailto:ros-dev-bounces at reactos.com] On Behalf Of art yerkes
> Sent: Wednesday, September 29, 2004 3:16 PM
> To: ReactOS Development List
> Cc: welch at cwcom.net
> Subject: Re: [ros-dev] ASSERT_IRQL and unrelated mm/mdl.c
> 
> 
> On Wed, 29 Sep 2004 09:01:55 +0100
> David Welch <welch at cwcom.net> wrote:
> 
> > On Tue, Sep 28, 2004 at 11:16:35PM -0500, art yerkes wrote:
> > > There are a couple of other places where 
> MmNotPresentFault is called
> > > (section.c) within a MmLockAddressSpace.  Another idea 
> would be to give
> > > MmNotPresentFault and MmAccessFault an extra argument so 
> they can ignore
> > > locking if the address space is already locked.
> > >
> > Isn't that what already happens? The FromMdl argument. And 
> isn't the address
> > space lock a fast mutex not a spinlock?
> 
> It wasn't always honored but Hartmut fixed it in mm/mm.c 
> without my noticing
> (1.76).  Sorry I fell behind.
> -- 
> Hey, Adam Smith, keep your invisible hands to yourself!
> _______________________________________________
> Ros-dev mailing list
> Ros-dev at reactos.com
> http://reactos.com:8080/mailman/listinfo/ros-dev
>