[ros-dev] Re: [ros-cvs] CVS Update: reactos

[Alex Ionescu]

Filip Navara wrote:

> Alex Ionescu wrote:
>
>> Hi,
>>
>> Please reverse this change. ExInterlocked* functions are FASTCALL, as 
>> previously defined.
>
>
> Some are, some aren't! If you were looking in the DDK headers you'll see
>
>    #define ExInterlockedXxx ExfInterlockedXxx
>    ...
>    ULONG DDKFASTAPI
>    ExInterlockedXxx(...);
>
> which is confusing, but trust me I got the prototypes right.

If you were looking in the DDK headers you'll see:

NTKERNELAPI
ULONG
FASTCALL
ExInterlockedAddUlong (
    IN PULONG Addend,
    IN ULONG Increment,
    IN PKSPIN_LOCK Lock
    );

after your change our headers have:

ULONG STDCALL
ExInterlockedAddUlong (PULONG        Addend,
               ULONG        Increment,
               PKSPIN_LOCK    Lock)


I was however stupid in assuming all the STDCALL incorrections were your 
fault, it seems they were there before (except this one which you've done).

Anyways, the defintions are wrong and should be changed to FASTCALL, 
(the ones which are). The others should be macros in winddk.h which 
point to the fastcall versions. I haven't seen any STDCALL Ex functions 
in NTOSKRNL, please point them out to me.

I'm sorry for putting all the blame on you, I noticed you correctly 
changed some to FASTCALL in list.c.

Best regards,
Alex Ionescu

>
> Regards,
> Filip
> _______________________________________________
> Ros-dev mailing list
> Ros-dev at reactos.com
> http://reactos.com:8080/mailman/listinfo/ros-dev
>