[ros-dev] Re: [ros-cvs] CVS Update: reactos

[Casper Hornstrup]

> Casper,
> 
> I will be one of the first people to stand up in line and 
> yell "we need tests", and I strongly agree with all your 
> points, but you misunderstood mine.
> 
> My points were:
> 1) It is, in my opinion, cleaner to have a tests directory 
> separate (This doesn't mean optional or not included or 
> whatever, it will work the same way as you said). This is 
> personal choice and debatable.

My arguments against it are:

* It will cause them not to be maintained. If a component is
moved then it is likely that possible related test are not
moved with them. I've seen this before. This was also the
reason I was pro inline API status data. Had the API status
data been in separate files they would likely not have been
maintained as good as they are today.

* It makes the build system even more complex. Now you also have
to tell the tests where to find the component containing the
domain code and tell the component where to find the related
tests (so "make test" works). This adds extra dependencies.

> 2) It is, factually, adding to the ReactOS direcotry what 
> ****USERS**** will consider as junk. I run multiple programs 
> from CVS, where I just build them. But I am not a developer 
> for those projects. Nothing bugs me more then downloading 
> 15MB worth of CVS files out of which only 4MB are source code 
> and the other 11MB are stuff only the devs would want/need.
> 

Why can't you use the prebuilt binaries or packaged source code?
The repository is and will always be a tool for the developers.
Users should never have to use it and if they want to be wannabe
developers they need to accept the consequences of their actions.

Casper

> What I meant by "unnormal" code was code that is not part of 
> the React Operating System. I didn't mean it as not part of 
> the ReactOS Project. 
> By not part of, I mean that it doesn't export or provide any 
> functions that are compiled into the system. That's all.
> 
> So so reiterate, I have nothing against XP and I think tests 
> are very valuable. I was just giving my opinion that I think 
> they are in the wrong place.
> 
> Best regards,
> Alex Ionescu