[ros-dev] Re: [ros-cvs] CVS Update: reactos

[Ge van Geldorp]

> From: James Tabor
> 
> Hi!
> 
> Ge van Geldorp wrote:
> > Modified files:
> > 	reactos/lib/shlwapi/: Makefile.ros-template
> > 
> > Log message:
> > 	Simplify wine/shlwapi.h
> > 
> 
> Not to sure how this started time wise,
> 
> i386-mingw32-gcc -DWINSHLWAPI= -D_SHLWAPI_ -D__USE_W32API 
> -D_WIN32_IE=0x600 -D_WIN32_WINNT=0x501 
> -DWINVER=0x501 -D_STDDEF_H -I../../include/wine 
> -I../../include -I../../w32api/include -pipe 
> -march=i486 -D_M_IX86 -c msgbox.c -o msgbox.o
> In file included from msgbox.c:23:
> ../../include/wine/port.h:248: error: parse error before "pread"
> ../../include/wine/port.h:248: warning: data definition has 
> no type or storage class
> ../../include/wine/port.h:252: error: parse error before "pwrite"
> ../../include/wine/port.h:252: warning: data definition has 
> no type or storage class

No problem with GCC 3.4.1 on Windows, which is why I didn't notice it.
http://reactos.com:8080/archives/public/ros-cvs/2004-October/005776.html
should fix it.

I don't see the point of the use of the __REACTOS__ preprocessor symbol in
our tree. I think we should just remove "#ifdef __REACTOS__" lines and
remove the code inactivated by "#ifndef __REACTOS__". After all, we are
ALWAYS compiling for ReactOS in our tree.

If noone objects, I'll change it this weekend.

Ge van Geldorp.