[ros-dev] Re: [ros-cvs] CVS Update: reactos

[Alex Ionescu]

Hartmut Birr wrote:

>CVSROOT:	/CVS/ReactOS
>Module name:	reactos
>Repository:	reactos/ntoskrnl/include/internal/i386/
>Changes by:	hbirr at mok.osexperts.com	04/10/17 03:53:08
>
>Modified files:
>	reactos/ntoskrnl/include/internal/i386/: ps.h 
>
>Log message:
>	- Fixed the definition KPCR_SELF and KeGetCurrentKPCR.
>
>_______________________________________________
>Ros-cvs mailing list
>Ros-cvs at reactos.com
>http://reactos.com/mailman/listinfo/ros-cvs
>
>  
>
Is that really right? I can swear fs:18h was still used until NT 5.2.
Also, it would be of critical importance to:
    1) Change the hardcoded offsets to FIELD_OFFSET(...,...)
    2) Make the ASM use the defines instead of hardcoding 1Ch/18h

Best regards,
Alex Ionescu