[ros-dev] Wineism

[Steven Edwards]

Hi,

--- Casper Hornstrup <chorns at users.sourceforge.net> wrote:
> You are completely ignoring the resources it requires to share
> code. If you cannot share the whole component and without #ifdef
> this and that then don't do it at all. If you want to rewrite
> the lower level WINE and ReactOS components, then be my guest,
> but it is a lot of work and it puts more restrictions on both
> projects.

Some of the source files can be taken with only changing the header
files. Read the comment in this patch

http://cvs.reactos.com/cgi-bin/cvsweb.cgi/reactos/lib/kernel32/misc/profile.c.diff?r1=1.15&r2=1.16

By changing the formating just to make it look like the coding style in the rest of the dll makes
generating a diff of a change later almost imposssible. The question is "Why should we rewrite
large sections of code that can be shared with Wine just because of coding style issues?".

Here is another example. This file was rippped from Wine. Other than the header changes the
function body is intact.

http://cvs.reactos.com/cgi-bin/cvsweb.cgi/reactos/lib/gdi32/objects/linedda.c?rev=1.4&content-type=text/x-cvsweb-markup

Should I be forced to reformat it to match the coding style in the rest of the dll which will then
make generating diffs a pain?

Thanks
Steven



		
__________________________________ 
Do you Yahoo!? 
Dress up your holiday email, Hollywood style. Learn more. 
http://celebrity.mail.yahoo.com