[ros-dev] Re: [ros-cvs] CVS Update: reactos

[Gunnar Dalsnes]

I saw Steven doing some dewineism commits also.

But why remove wineism?
It will be much easier to see differences with wine code when fixing 
bugs etc. if the code in question was taken from wine and wine for 
example has fixed a bug we are hunting. In kernel32 there are some files 
that i have taken from wine and the only thing changed is the include 
files, to make it possible to merge wine changes back.

> CVSROOT:	/CVS/ReactOS
> Module name:	reactos
> Repository:	reactos/lib/advapi32/crypt/
> Changes by:	ekohl at mok.osexperts.com	04/12/12 07:16:27
> 
> Modified files:
> 	reactos/lib/advapi32/crypt/: crypt.c crypt.h crypt_des.c 
> 	                             crypt_lmhash.c crypt_md4.c 
> 	                             crypt_md5.c crypt_sha.c 
> 
> Log message:
> 	- Remove Wine-isms from advapi32 because it's a ReactOS DLL!

"because it's a ReactOS DLL"? So if we have to change one file out of 
many to adapt a wine dll as ours, we have to dewineism all other files 
also?

> 	- Enforce a consistent coding style.
> 	- Remove -D__REACTOS__
> 
> _______________________________________________
> Ros-cvs mailing list
> Ros-cvs at reactos.com
> http://reactos.com/mailman/listinfo/ros-cvs
> 
> 
> 
>