[ros-dev] Re: [ros-cvs] CVS Update: reactos

[Hartmut Birr]

Gregor Anich schrieb:

>CVSROOT:	/CVS/ReactOS
>Module name:	reactos
>Repository:	reactos/ntoskrnl/include/
>Changes by:	blight at mok.osexperts.com	04/12/10 06:58:26
>
>Modified files:
>	reactos/ntoskrnl/dbg/: print.c 
>	reactos/ntoskrnl/include/: config.h 
>
>Log message:
>	Add an option to serialize DbgPrint - don't worry, it's disabled by default and meant only for those who are tired of reading mixed debug messages.
>
>_______________________________________________
>Ros-cvs mailing list
>Ros-cvs at reactos.com
>http://reactos.com/mailman/listinfo/ros-cvs
>
>
>  
>
Hi,  

I like your idea. For my smp build, I've add a simple spinlock which 
does serialize the access to the real debug print function. Your 
implementation has two problems. The first, it is possible to call 
DbgPrint from each interupt level, so it isn't possible to use 
ExAllocatePool. The second, we have nice macros like DPRINT, CPRINT or  
KEBUGCHECK, which calls DbgPrint for twice. This should be merged in one 
call.   

- Hartmut