[ros-dev] [ros-diffs] [ion] 24773: - MSVC VCPROJ Maker: * Don't insert NDEBUG as a define, files define this manually already. * Don't add _CRT flags, since the RTM WDK defines them properly. * Force warning.h to be i ncluded just like the WDK does. * Disable WP

Murphy, Ged (Bolton) Ged.Murphy at eu.exide.com
Fri Nov 17 09:17:38 CET 2006


ion at svn.reactos.org wrote:

> - Please remember that you NEED the WDK 6000 RTM installed to 
> use MSVC for building ReactOS. Don't change global build 
> settings just because you were too lazy to download it and 
> think that because your Win32 app doesn't need it, it's ok to 
> break other people's native/system/kernel/hal builds. Change 
> it locally if you're lazy, but don't revert these changes again.

I highly dissagree that we should break building of usermode code in MSVC
just because someone doesn't have 1 header file which is included with the
WDK.
If it effects the building of HAL etc so much, then it should be a
requirement for those components only, not for wingui/win32dll code.

Maybe including a similar header into our own code is a more viable option.

Ged.


More information about the Ros-dev mailing list