[ros-dev] Problem drawing the desktop in the updated color

[Timo Kreuzer]

Saveliy Tretiakov schrieb:
> Timo Kreuzer ?????:
>   
>> 1.) IntGetSysColorBrush is a fuction I wrote to make things easie
>>     
> It is already implemented (see r23525).
>   
Funny, my working copy was only 5 revisions behind ;-)
I also implemented IntGetSysColor.

> HGDIOBJ FASTCALL
> IntGetSysColorBrush(INT Object)
> {
>   return ((Object < 0) || (NUM_SYSCOLORS <= Object)) ? NULL : 
> SysColorBrushes[Object];
> }
First question:
Is there a reason you used HGDIOBJ and DWORD instead of HBRUSH and 
COLORREF (that's what I used).

Second question:
Wouldn't an "(UINT Object)" make life easier here? There would be no 
need for (Object < 0) (?)
IntGetSysColor also uses an INT instead of UINT.
Just my 3,1415 cents ;-)
Timo


-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://www.reactos.org/pipermail/ros-dev/attachments/20060810/010616cd/attachment.html